sureshanaparti commented on a change in pull request #4790:
URL: https://github.com/apache/cloudstack/pull/4790#discussion_r639448021
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -219,6 +224,8 @@ public String toString() {
private static final ConfigKey<String> statsOutputUri = new
ConfigKey<String>("Advanced", String.class, "stats.output.uri", "",
"URI to send StatsCollector statistics to. The collector is
defined on the URI scheme. Example: graphite://graphite-hostaddress:port or
influxdb://influxdb-hostaddress/dbname. Note that the port is optional, if not
added the default port for the respective collector (graphite or influxdb) will
be used. Additionally, the database name '/dbname' is also optional; default
db name is 'cloudstack'. You must create and configure the database if using
influxdb.",
true);
+ private static final ConfigKey<Double> secondaryStorageCapacityThreshold =
new ConfigKey<Double>("Advanced", Double.class,
"secondary.storage.capacity.threshold", "0.90",
Review comment:
The description for most of the percentage based configs clear indicate
that values should be between 0 and 1, and same is being validated in the
configuration manager. can you search code with string '_Percentage (as a value
between 0 and 1)_ ' and update the config description as appropriate. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
