rhtyd commented on a change in pull request #5017:
URL: https://github.com/apache/cloudstack/pull/5017#discussion_r642335714



##########
File path: 
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
##########
@@ -884,6 +889,18 @@ private void checkStatusOfCurrentlyExecutingBackups() {
         }
     }
 
+    @DB
+    public void cleanupBackups() {

Review comment:
       Since we're already removing backups in the VM expunge logic this is not 
needed. Could it cause any regression? (I understand you're ensuring that VMs 
without backups are removed from offering).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to