rhtyd commented on a change in pull request #5017:
URL: https://github.com/apache/cloudstack/pull/5017#discussion_r642383498
##########
File path:
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
##########
@@ -671,6 +667,14 @@ public boolean deleteBackup(final Long backupId) {
if (offering == null) {
throw new CloudRuntimeException("VM backup offering ID " +
vm.getBackupOfferingId() + " does not exist");
}
+ List<Backup> backupsForVm = backupDao.listByVmId(vm.getDataCenterId(),
vmId);
+ if (CollectionUtils.isNotEmpty(backupsForVm)) {
Review comment:
I checked this may cause regression for Veeam @Pearl1594 this code is
not necessary I think, even for dummy provider. On deletion of a backup, it
shouldn't remove from offering - also as long a backup exists we'll never this
logic right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
