GutoVeronezi commented on a change in pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#discussion_r646640959



##########
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -3459,6 +3457,8 @@ public boolean isCentosHost() {
                 platformEmulator.startsWith("Oracle") ||
                 platformEmulator.startsWith("Other PV")) {
             return DiskDef.DiskBus.VIRTIO;
+        } else if (isUefiEnabled && (platformEmulator.startsWith("Windows") || 
platformEmulator.startsWith("Other"))) {

Review comment:
       To simplify those validations, we could use `StringUtils.startsWithAny`, 
from `commons.lang3`:
   
   ```java
   StringUtils.startsWithAny(platformEmulator, ...
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to