slavkap commented on a change in pull request #5072:
URL: https://github.com/apache/cloudstack/pull/5072#discussion_r646815099
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -3459,6 +3457,8 @@ public boolean isCentosHost() {
platformEmulator.startsWith("Oracle") ||
platformEmulator.startsWith("Other PV")) {
return DiskDef.DiskBus.VIRTIO;
+ } else if (isUefiEnabled && (platformEmulator.startsWith("Windows") ||
platformEmulator.startsWith("Other"))) {
Review comment:
@GutoVeronezi, I saw your suggestion, and I like it, but I'm not sure
that I have to do it. The first is because I was following the rest of the
statement to be in the "same style", and it's a small fix, not a refactoring.
Another thing is in `LibvirtComputingResource` is used
`com.cloud.utils.StringUtils` and `org.apache.commons.lang.StringUtils`, for
me, it's going to be a mess if we use and `commons.lang3`.
Anyway, I will make the change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
