harikrishna-patnala opened a new pull request #5097: URL: https://github.com/apache/cloudstack/pull/5097
### Description This PR fixes the problem of not updating the chain info or setting chain info to null after volume migrations. Problem: While fetching the volume chain info, management server assumes datastore name to be a UUID (this is true only for NFS storages added by CloudStack) but datastore name can be with any name. Solution: To fetch the volume chain info, use datastore name instead of UUID. The fix is made in the flow of following API operations 1. migrateVirtualMachine 2. migrateVirtualMachineWithVolume 3. migrateVolume <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Created one NFS, one datastore cluster (with two child storages with names "child1", "child2") primary storages 1. Migrated a volume from NFS to datastore cluster. 'chain_info' in "volumes" table is updated Before migration  After migration  2. Migrated volume from datastore cluster to NFS storage. 'chain_info' in "volumes" table is updated 3. called APIs migrateVirtualMachine and migrateVirtualMachineWithVolumes to migrate volumes from NFS to datastore cluster and datastore cluster to NFS, all succeeded and updated the chain_info accordingly. <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
