Pearl1594 commented on a change in pull request #5125:
URL: https://github.com/apache/cloudstack/pull/5125#discussion_r654122992
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -1457,7 +1457,7 @@ protected VolumeVO retrieveAndValidateVolume(long
volumeId, Account caller) {
* The volume is destroyed via {@link VolumeService#destroyVolume(long)}
method.
*/
protected void destroyVolumeIfPossible(VolumeVO volume) {
- if (volume.getState() != Volume.State.Destroy && volume.getState() !=
Volume.State.Expunging && volume.getState() != Volume.State.Expunged &&
volume.getState() != Volume.State.Allocated && volume.getState() !=
Volume.State.Uploaded) {
+ if (volume.getState() != Volume.State.Destroy && volume.getState() !=
Volume.State.Expunging && volume.getState() != Volume.State.Expunged &&
volume.getState() != Volume.State.Allocated) {
Review comment:
Thanks for the review @GabrielBrascher. I've addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
