sureshanaparti commented on a change in pull request #5130:
URL: https://github.com/apache/cloudstack/pull/5130#discussion_r655267427
##########
File path:
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/CephSnapshotStrategy.java
##########
@@ -64,10 +64,6 @@ public StrategyPriority canHandle(Snapshot snapshot,
SnapshotOperation op) {
return StrategyPriority.HIGHEST;
}
- if (SnapshotOperation.DELETE.equals(op)) {
- return StrategyPriority.HIGHEST;
- }
-
Review comment:
code LGTM, as delete op is not handled here, it shouldn't consider this
strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
