sureshanaparti commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r655389615



##########
File path: engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java
##########
@@ -103,11 +146,16 @@ public ServiceOfferingVO(String name, Integer cpu, 
Integer ramSize, Integer spee
         volatileVm = false;
         this.defaultUse = defaultUse;
         this.vmType = vmType == null ? null : vmType.toString().toLowerCase();
+        uuid = UUID.randomUUID().toString();
+        this.systemUse = systemUse;
+        this.name = name;
+        this.displayText = displayText;
     }
 
-    public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, 
Integer speed, Integer rateMbps, Integer multicastRateMbps, boolean offerHA, 
boolean limitCpuUse,
-                             boolean volatileVm, String displayText, 
ProvisioningType provisioningType, boolean useLocalStorage, boolean 
recreatable, String tags, boolean systemUse, VirtualMachine.Type vmType) {
-        super(name, displayText, provisioningType, false, tags, recreatable, 
useLocalStorage, systemUse, true);
+    public ServiceOfferingVO(String name, Integer cpu, Integer ramSize, 
Integer speed, Integer rateMbps, Integer multicastRateMbps, boolean offerHA,
+                             boolean limitResourceUse, boolean volatileVm, 
String displayText, ProvisioningType provisioningType, boolean useLocalStorage, 
boolean recreatable, String tags, boolean systemUse,
+                             VirtualMachine.Type vmType, String hostTag, 
String deploymentPlanner) {
+        //super(name, displayText, provisioningType, false, tags, recreatable, 
useLocalStorage, systemUse, true);

Review comment:
       +1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to