davidjumani commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r657607350
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java
##########
@@ -94,7 +94,6 @@
@Parameter(name = ApiConstants.SUPPORTED_SERVICES,
type = CommandType.LIST,
- required = true,
Review comment:
For L2 network offerings, there are cases when there are no services,
and an empty list is sent, so marking it as not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]