rhtyd commented on a change in pull request #5136:
URL: https://github.com/apache/cloudstack/pull/5136#discussion_r660354481
##########
File path: server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
##########
@@ -159,6 +159,9 @@ public void processParameters(final BaseCmd cmd, final Map
params) {
}
continue;
}
+ if (parameterAnnotation.required()){
+ validateNonEmptyString(paramObj, parameterAnnotation.name());
Review comment:
LGTM - my only worry is if it causes a regression as it create a new
behaviour (nit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
