Spaceman1984 commented on a change in pull request #4701:
URL: https://github.com/apache/cloudstack/pull/4701#discussion_r657649748
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManager.java
##########
@@ -46,6 +46,9 @@
static final ConfigKey<Integer> s_vmwareOVAPackageTimeout = new
ConfigKey<Integer>(Integer.class, "vmware.package.ova.timeout", "Advanced",
"3600",
"Vmware script timeout for ova packaging process", true,
ConfigKey.Scope.Global, 1000);
+ static final ConfigKey<Boolean> s_vmwareCleanupPortGroups = new
ConfigKey<Boolean>("Advanced", Boolean.class, "vmware.cleanup.port.groups",
"false",
+ "Remove unused port groups. WARNING: When set to true, native
VMware HA might not work.", true, ConfigKey.Scope.Global);
Review comment:
> Hi @Spaceman1984 there are some open questions on this PR, can you
please advise?
Sure @nvazquez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
