Spaceman1984 commented on a change in pull request #4701:
URL: https://github.com/apache/cloudstack/pull/4701#discussion_r657650015
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManager.java
##########
@@ -46,6 +46,9 @@
static final ConfigKey<Integer> s_vmwareOVAPackageTimeout = new
ConfigKey<Integer>(Integer.class, "vmware.package.ova.timeout", "Advanced",
"3600",
"Vmware script timeout for ova packaging process", true,
ConfigKey.Scope.Global, 1000);
+ static final ConfigKey<Boolean> s_vmwareCleanupPortGroups = new
ConfigKey<Boolean>("Advanced", Boolean.class, "vmware.cleanup.port.groups",
"false",
+ "Remove unused port groups. WARNING: When set to true, native
VMware HA might not work.", true, ConfigKey.Scope.Global);
Review comment:
To my knowledge, this setting is not used through garbage collection, it
is checked when an instance is destroyed. I'm not sure if there is some kind of
garbage collection that would destroy a VR, if there is, then I suppose this
will also apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
