sureshanaparti commented on a change in pull request #4378:
URL: https://github.com/apache/cloudstack/pull/4378#discussion_r658547304



##########
File path: 
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java
##########
@@ -155,6 +161,8 @@ public void execute() {
                 throw new InvalidParameterValueException("The specified host(" 
+ destinationHost.getName() + ") is not suitable to migrate the VM, please 
specify another one");
             }
             CallContext.current().setEventDetails("VM Id: " + 
getVirtualMachineId() + " to host Id: " + getHostId());
+        } else if (! isAutoSelect()) {
+            throw new InvalidParameterValueException("Please specify a host or 
storage as destination, or pass 'autoselect=true' to automatically select a 
destination host which do not require storage migration");

Review comment:
       @weizhouapache just to check, auto select here picks the suitable host 
for VM migration. In the similar way, any possibility to pick suitable storage 
? If so, can this API have both parameters: autoselecthost & autoselectstorage 
(only one of them should be true).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to