sureshanaparti commented on a change in pull request #5163:
URL: https://github.com/apache/cloudstack/pull/5163#discussion_r661402061
##########
File path: server/src/main/java/com/cloud/uuididentity/UUIDManagerImpl.java
##########
@@ -119,7 +119,7 @@ public boolean IsUuidFormat(String uuid) {
}
Identity identity = (Identity) this._entityMgr.findById(entityType,
customId);
if (identity == null) {
- throw new InvalidParameterValueException("Unable to find UUID for
id " + customId);
+ throw new InvalidParameterValueException(String.format("Unable to
find UUID for id %s of type %s", customId, entityType.getSimpleName()));
Review comment:
@DaanHoogland If entityType is null, the resultant dao is null and can
be a potential NPE. May be this extra null check here can guard, and you can
keep the entity type in error message.
```
if (customId == null || entityType == null) {
return null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
