DaanHoogland commented on a change in pull request #5163:
URL: https://github.com/apache/cloudstack/pull/5163#discussion_r660383593
##########
File path: server/src/main/java/com/cloud/uuididentity/UUIDManagerImpl.java
##########
@@ -119,7 +119,7 @@ public boolean IsUuidFormat(String uuid) {
}
Identity identity = (Identity) this._entityMgr.findById(entityType,
customId);
if (identity == null) {
- throw new InvalidParameterValueException("Unable to find UUID for
id " + customId);
+ throw new InvalidParameterValueException(String.format("Unable to
find UUID for id %s of type %s", customId, entityType.getSimpleName()));
Review comment:
it could but it would have thrown an error in line 120 I thought about
```suggestion
throw new InvalidParameterValueException(String.format("Unable
to find UUID for id %s of type %s",
customId,
(entityType == null ? "<unknown type>" ? entityType.getSimpleName())));
```
I wasn't sure if it was needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
