davidjumani commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r673873927
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##########
@@ -139,6 +141,9 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
}
}
+
if(StringUtils.isEmpty(details.get(VmDetailConstants.RAM_RESERVATION))){
Review comment:
Could cause an issue if the user does not want to reserve memory for a
VM and passes 0.0, better to leave it unset and check whether the key exists in
getReservedMemoryMb (Tested, passing 0.0 causes memory to be reserved)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
