harikrishna-patnala commented on a change in pull request #5228:
URL: https://github.com/apache/cloudstack/pull/5228#discussion_r674497906
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -306,7 +307,7 @@ public boolean configure(String name, Map<String, Object>
params) throws Configu
_storage.configure("StorageLayer", params);
}
- value = _configDao.getValue(Config.VmwareCreateFullClone.key());
Review comment:
I think this is the only usage that makes the configuration parameter
not dynamic. Can we not use any indirect variables and make the parameter
dynamic @Pearl1594 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
