DK101010 commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r674520599
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##########
@@ -139,6 +141,9 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
}
}
+
if(StringUtils.isEmpty(details.get(VmDetailConstants.RAM_RESERVATION))){
Review comment:
Hi @davidjumani , thanks for testing. It strange that it not work this
line in getReservedMemory should prevent this
```java
if(!NumberUtils.DOUBLE_ZERO.toString().equals(vmSpec.getDetails().get(VmDetailConstants.RAM_RESERVATION))){
```
But the Method returns every time the minimum ram.
```java
return (int) (vmSpec.getMinRam() / ResourceType.bytesToMiB);
```
Could it be in your test case that the reserved memory = minimum ram is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
