DK101010 commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r683167140
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -549,12 +549,6 @@ public static void
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
cpuInfo.setReservation((long)cpuReservedMhz);
vmConfig.setCpuAllocation(cpuInfo);
- if (cpuSpeedMHz != cpuReservedMhz) {
Review comment:
Hi @nvazquez not sure what do you mean with regression.
Reservation and hot add are two different things. I can use reservation in
it doesn't matter if hot add enabled/disbaled and it makes for me not sense to
enable this when I'm reserve memory .
Also you can't more reserve as you have for the current vm.
I may be missing something, but currently I don't see a problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
