GutoVeronezi commented on pull request #5239:
URL: https://github.com/apache/cloudstack/pull/5239#issuecomment-885612499


   @DaanHoogland @nvazquez as we discussed, I created a new PR proposing the 
reverted work. At the time you raised the issue (in 
https://github.com/apache/cloudstack/pull/4585#issuecomment-882565561), I did 
not have a chance to investigate and validate it. I understand the use of 
revert to get things working. However, recently I made some tests with the PR 
and `addHost`'s feature is working (you can see one 
[HERE](https://www.youtube.com/watch?v=0loAaOFOipU)). Therefore, it does not 
seem to be a problem with the PR itself; analyzing the logs, the issue you 
showed us seems related to the environment.
   
   I think that next time something like this happens, we should investigate 
the real problem and pin point it in some part of the code, instead of just 
reverting the first thing we see in hopes that this fixes the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to