davidjumani commented on a change in pull request #4766:
URL: https://github.com/apache/cloudstack/pull/4766#discussion_r676299161
##########
File path: ui/src/views/network/FirewallRules.vue
##########
@@ -426,38 +442,44 @@ export default {
this.closeModal()
})
},
- handleAddTag () {
+ handleAddTag (e) {
+ e.preventDefault()
+ if (this.addTagLoading) return
this.addTagLoading = true
- api('createTags', {
- 'tags[0].key': this.newTag.key,
- 'tags[0].value': this.newTag.value,
- resourceIds: this.selectedRule,
- resourceType: 'FirewallRule'
- }).then(response => {
- this.$pollJob({
- jobId: response.createtagsresponse.jobid,
- successMessage: this.$t('message.success.add.tag'),
- successMethod: () => {
- this.parentToggleLoading()
- this.openTagsModal(this.selectedRule)
- },
- errorMessage: this.$t('message.add.tag.failed'),
- errorMethod: () => {
- this.parentToggleLoading()
- this.closeModal()
- },
- loadingMessage: this.$t('message.add.tag.processing'),
- catchMessage: this.$t('error.fetching.async.job.result'),
- catchMethod: () => {
- this.parentFetchData()
- this.parentToggleLoading()
- this.closeModal()
- }
+
+ this.newTagsForm.validateFields((err, values) => {
+ if (err) {
+ this.tagsLoading = false
+ return
+ }
+
+ api('createTags', {
+ 'tags[0].key': values.key,
+ 'tags[0].value': values.value,
+ resourceIds: this.selectedRule,
+ resourceType: 'FirewallRule'
+ }).then(response => {
+ this.$pollJob({
+ jobId: response.createtagsresponse.jobid,
+ successMessage: this.$t('message.success.add.tag'),
+ successMethod: () => {
+ this.parentToggleLoading()
+ this.openTagsModal(this.selectedRule)
+ },
+ errorMessage: this.$t('message.add.tag.failed'),
+ errorMethod: () => {
+ this.parentToggleLoading()
+ this.closeModal()
+ },
+ loadingMessage: this.$t('message.add.tag.processing'),
+ catchMessage: this.$t('error.fetching.async.job.result'),
+ catchMethod: () => {
+ this.parentFetchData()
+ this.parentToggleLoading()
+ this.closeModal()
+ }
+ })
})
- }).catch(error => {
- this.$notifyError(error)
- }).finally(() => {
- this.addTagLoading = false
Review comment:
This needs to be there, else the form is unusable after submitting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
