sureshanaparti commented on a change in pull request #3724:
URL: https://github.com/apache/cloudstack/pull/3724#discussion_r682468064
##########
File path: api/src/main/java/com/cloud/storage/Snapshot.java
##########
@@ -48,7 +48,7 @@ public boolean equals(String snapshotType) {
}
public enum State {
- Allocated, Creating, CreatedOnPrimary, BackingUp, BackedUp, Copying,
Destroying, Destroyed,
+ Allocated, AllocatedVM, Creating, CreatingForVM, CreatedOnPrimary,
CreatedOnPrimaryForVM, BackingUp, BackingUpForVM, BackedUp, BackedUpForVM,
Copying, Destroying, Destroyed,
Review comment:
@slavkap Some questions.
- Does the snapshot operation here triggered through VM snapshot operation
(as there are changes in VM snapshot strategies)?
- Are the actual volume snapshots taken (for the volumes of the VM) are
maintained at volume level (in snapshots table)?
- Does the snapshots taken here are listed with VM snapshots or volume
snapshots?
If the snapshots here are VM level snapshots, i think it is better to move
these new states (and associated state transitions) to VM Snapshot object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
