sureshanaparti commented on a change in pull request #3724:
URL: https://github.com/apache/cloudstack/pull/3724#discussion_r694911422
##########
File path: api/src/main/java/com/cloud/storage/Snapshot.java
##########
@@ -48,7 +48,7 @@ public boolean equals(String snapshotType) {
}
public enum State {
- Allocated, Creating, CreatedOnPrimary, BackingUp, BackedUp, Copying,
Destroying, Destroyed,
+ Allocated, AllocatedVM, Creating, CreatingForVM, CreatedOnPrimary,
CreatedOnPrimaryForVM, BackingUp, BackingUpForVM, BackedUp, BackedUpForVM,
Copying, Destroying, Destroyed,
Review comment:
> > * Does the snapshot operation here triggered through VM snapshot
operation (as there are changes in VM snapshot strategies)?
>
> Yes, it's triggered through the VM snapshot operation.
>
> > * Are the actual volume snapshots taken (for the volumes of the VM) are
maintained at volume level (in snapshots table)?
>
> They are maintained mostly at the VM level. You will see a volume
snapshot, but you don't have any options to operate separately on it.
>
> > * Does the snapshots taken here are listed with VM snapshots or volume
snapshots?
>
> You'll see both a VM snapshot and also a volume snapshot for each volume
of the group snapshot.
>
>
>
@slavkap As no operations can be performed on the volume snapshots (of the
VM) and these are read-only, I feel it is better to keep the snapshot as VM
snapshot only and maintain the relation of these volume snapshots to VM
snapshot at the backend (in DB). Also, better to move these new states (and
associated state transitions) to VM Snapshot object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
