davidjumani commented on a change in pull request #5215:
URL: https://github.com/apache/cloudstack/pull/5215#discussion_r685692173
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
##########
@@ -153,9 +153,12 @@
@Parameter(name = ApiConstants.USER_DATA, type = CommandType.STRING,
description = "an optional binary data that can be sent to the virtual machine
upon a successful deployment. This binary data must be base64 encoded before
adding it to the request. Using HTTP GET (via querystring), you can send up to
2KB of data after base64 encoding. Using HTTP POST(via POST body), you can send
up to 32K of data after base64 encoding.", length = 32768)
private String userData;
- @Parameter(name = ApiConstants.SSH_KEYPAIR, type = CommandType.STRING,
description = "name of the ssh key pair used to login to the virtual machine")
+ @Parameter(name = ApiConstants.SSH_KEYPAIR, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "name of the ssh key pairs
used to login to the virtual machine")
Review comment:
This should not be changed
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vm/ResetVMSSHKeyCmd.java
##########
@@ -58,8 +60,11 @@
@Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
UserVmResponse.class, required = true, description = "The ID of the virtual
machine")
private Long id;
- @Parameter(name = ApiConstants.SSH_KEYPAIR, type = CommandType.STRING,
required = true, description = "name of the ssh key pair used to login to the
virtual machine")
- private String name;
+ @Parameter(name = ApiConstants.SSH_KEYPAIR, type = CommandType.LIST,
collectionType = CommandType.STRING ,description = "name of the ssh key pair to
bt used to login to the virtual machine")
Review comment:
This too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
