rhtyd commented on a change in pull request #5320:
URL: https://github.com/apache/cloudstack/pull/5320#discussion_r690289106
##########
File path: framework/db/src/main/java/com/cloud/utils/db/Filter.java
##########
@@ -77,7 +77,9 @@ public void addOrderBy(Class<?> clazz, String field, boolean
ascending) {
Column column = f.getAnnotation(Column.class);
String name = column != null ? column.name() : field;
-
+ if (!name.equals("id")) {
+ name = String.format("%s, id", name);
Review comment:
What if the table has no `id` column @shwstppr the change is in `Filter`
class and could have widespread side-effects. Can we check the service layer
handler specific to listServiceOfferings and do something isolated/specific to
that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
