weizhouapache commented on pull request #4200: URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-902567828
> What is the scope of this PR? the conversation seems to have moved in multiple directions. It seems like this should be separate threads, probably of separate PRs. > > * I still can't see why it's such a big deal for a domain admin to include the domain id of where they want an offering created. > If they're using the UI we can set the domain field to default to that domain, if they're using the API directly (ie via cmk) then it's a good validation that they're doing what they meant to, and if they're using some automation then the automation should deal with it. we could enfoce users to pass domainid and account when they deploy a instance. but we all agree it is unnecessary. users are smart and they know what they are doing. there is another example, when create a shared network by root admin (networks are more important than service offerings, right ?), acltype and domain/account are optional not required. if root admin forgets to pass acltype, the created network will be visible by all users. is it more risky ? if a change has no risk but make life a little bit easier, why not accept it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
