DaanHoogland commented on a change in pull request #5335:
URL: https://github.com/apache/cloudstack/pull/5335#discussion_r692935821
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1955,10 +1955,10 @@ protected void setVmBootDetails(final VM vm, final
Connection conn, String bootT
boolean isSecure =
bootType.equals(ApiConstants.BootType.UEFI.toString()) &&
ApiConstants.BootMode.SECURE.toString().equals(bootMode);
final Map<String, String> bootParams = vm.getHVMBootParams(conn);
- bootParams.replace("firmware", bootType);
+ bootParams.replace("firmware", bootType.toLowerCase());
vm.setHVMBootParams(conn, bootParams);
final Map<String, String> platform = vm.getPlatform(conn);
- platform.put("secureboot", isSecure ? "true" : "false");
+ platform.put("secureboot", Boolean.toString(isSecure));
Review comment:
How about making isSecure `Boolean` instead of `boolean` and than just
call isSecure.teString()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
