weizhouapache commented on pull request #5337: URL: https://github.com/apache/cloudstack/pull/5337#issuecomment-903077834
> @Pearl1594 sorry but I don't understand point of this change. We are removing `required` tag for API params but making them required again in API handling. > > Maybe the intention is to check `username`, `password` is not empty when they are passed but I don't think the check correspond to that. Sorry if I'm missing something. username and password can be empty when add a vmware host. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
