nvazquez commented on issue #3110:
URL: https://github.com/apache/cloudstack/issues/3110#issuecomment-903111629


   These are my test results using the main branch (4.16.0-SNAPSHOT) on KVM 
environment:
   
   - `scaleVirtualMachine` API always performs ROOT disk resize (despite global 
setting 'enable.dynamic.scale.vm' value or template/service offering dynamic 
scalable option checked) 
   - `changeServiceForVirtualMachine` does not perform ROOT disk resize even if 
the global setting, template and service offering values for dynamic scalling 
are enabled.
   
   Logs below:
   
   - 'enable.dynamic.scale.vm' = false, template dynamic sacallable = false, 
service offering dynamic scalable = true. `changeServiceForVirtualMachine` API:
   ````
   2021-08-20 18:01:52,872 DEBUG [c.c.a.ApiServlet] 
(qtp1233705144-341:ctx-800776c5) (logid:cb9770c5) ===START===  172.16.250.2 -- 
GET  
apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=changeServiceForVirtualMachine&id=9bbbad3b-2942-4bc5-817c-b9e69cd8c616&response=json&serviceofferingid=dbffb956-e1ea-4e23-aa3b-6ff86b802753&signature=5YtGFUZ6FfriqOe8fXyrF0fJAdQ%3D
   2021-08-20 18:01:52,875 DEBUG [c.c.a.ApiServer] 
(qtp1233705144-341:ctx-800776c5 ctx-5ba2640e) (logid:cb9770c5) CIDRs from which 
account 'Acct[8a72b754-cae7-11eb-aec6-1e0098000377-admin] -- Account {"id": 2, 
"name": "admin", "uuid": "8a72b754-cae7-11eb-aec6-1e0098000377"}' is allowed to 
perform API calls: 0.0.0.0/0,::/0
   2021-08-20 18:01:52,914 WARN  [o.a.c.f.j.AsyncJobExecutionContext] 
(qtp1233705144-341:ctx-800776c5 ctx-5ba2640e ctx-f4ef84af) (logid:cb9770c5) Job 
is executed without a context, setup psudo job for the executing thread
   2021-08-20 18:01:52,923 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(qtp1233705144-341:ctx-800776c5 ctx-5ba2640e ctx-f4ef84af) (logid:cb9770c5) 
Sync job-351 execution on object VmWorkJobQueue.28
   2021-08-20 18:01:53,956 INFO  [c.c.v.UserVmManagerImpl] 
(qtp1233705144-341:ctx-800776c5 ctx-5ba2640e ctx-f4ef84af) (logid:cb9770c5) VM 
cannot be configured to be dynamically scalable if any of the service 
offering's dynamic scaling property, template's dynamic scaling property or 
global setting is false
   2021-08-20 18:01:53,959 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp1233705144-341:ctx-800776c5 ctx-5ba2640e ctx-f4ef84af) (logid:cb9770c5) 
Updating resource Type = cpu count for Account = 2 Operation = increasing 
Amount = 1
   2021-08-20 18:01:53,962 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp1233705144-341:ctx-800776c5 ctx-5ba2640e ctx-f4ef84af) (logid:cb9770c5) 
Updating resource Type = memory count for Account = 2 Operation = increasing 
Amount = 1536
   2021-08-20 18:01:53,979 DEBUG [c.c.a.ApiServlet] 
(qtp1233705144-341:ctx-800776c5 ctx-5ba2640e ctx-f4ef84af) (logid:cb9770c5) 
===END===  172.16.250.2 -- GET  
apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=changeServiceForVirtualMachine&id=9bbbad3b-2942-4bc5-817c-b9e69cd8c616&response=json&serviceofferingid=dbffb956-e1ea-4e23-aa3b-6ff86b802753&signature=5YtGFUZ6FfriqOe8fXyrF0fJAdQ%3D
   ````
   
   - 'enable.dynamic.scale.vm' = true, template dynamic sacallable = true, 
service offering dynamic scalable = true `changeServiceForVirtualMachine` API 
attempts a ROOT disk resize and sends a resize command to the hypervisor agent 
but having currentSize = newSize = actual size of the ROOT volume. Then, no 
resize is performed:
   ````
   2021-08-20 18:31:22,053 DEBUG [c.c.a.ApiServlet] 
(qtp1233705144-341:ctx-ca45c685) (logid:eff47b8d) ===START===  172.16.250.2 -- 
GET  
apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=changeServiceForVirtualMachine&id=5298703e-2b13-454e-8dc7-a89391ca10cf&response=json&serviceofferingid=dbffb956-e1ea-4e23-aa3b-6ff86b802753&signature=g0bjxAG4fuAsPwwwr6xNdsAycNI%3D
   2021-08-20 18:31:22,056 DEBUG [c.c.a.ApiServer] 
(qtp1233705144-341:ctx-ca45c685 ctx-ca54d7a6) (logid:eff47b8d) CIDRs from which 
account 'Acct[8a72b754-cae7-11eb-aec6-1e0098000377-admin] -- Account {"id": 2, 
"name": "admin", "uuid": "8a72b754-cae7-11eb-aec6-1e0098000377"}' is allowed to 
perform API calls: 0.0.0.0/0,::/0
   2021-08-20 18:31:22,073 WARN  [o.a.c.f.j.AsyncJobExecutionContext] 
(qtp1233705144-341:ctx-ca45c685 ctx-ca54d7a6 ctx-99d68cd7) (logid:eff47b8d) Job 
is executed without a context, setup psudo job for the executing thread
   2021-08-20 18:31:22,078 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(qtp1233705144-341:ctx-ca45c685 ctx-ca54d7a6 ctx-99d68cd7) (logid:eff47b8d) 
Sync job-375 execution on object VmWorkJobQueue.29
   2021-08-20 18:31:23,892 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(AsyncJobMgr-Heartbeat-1:ctx-1d3bdd5b) (logid:cdda1cad) Execute sync-queue 
item: SyncQueueItemVO {id:129, queueId: 127, contentType: AsyncJob, contentId: 
375, lastProcessMsid: 32987898970999, lastprocessNumber: 3, lastProcessTime: 
Fri Aug 20 18:31:23 UTC 2021, created: Fri Aug 20 18:31:22 UTC 2021}
   2021-08-20 18:31:23,893 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(AsyncJobMgr-Heartbeat-1:ctx-1d3bdd5b) (logid:cdda1cad) Schedule queued job-375
   2021-08-20 18:31:23,897 INFO  [o.a.c.f.j.i.AsyncJobMonitor] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375) (logid:c1f6d0a0) Add 
job-375 into job monitoring
   2021-08-20 18:31:23,901 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375) (logid:cf6a9431) Executing 
AsyncJobVO {id:375, userId: 2, accountId: 2, instanceType: null, instanceId: 
null, cmd: com.cloud.vm.VmWorkResizeVolume, cmdInfo: 
rO0ABXNyAB9jb20uY2xvdWQudm0uVm1Xb3JrUmVzaXplVm9sdW1lVNN8x9BXvoICAAhKAAtjdXJyZW50U2l6ZUoAB25ld1NpemVaAAhzaHJpbmtPa0oACHZvbHVtZUlkTAAcbmV3SHlwZXJ2aXNvclNuYXBzaG90UmVzZXJ2ZXQAE0xqYXZhL2xhbmcvSW50ZWdlcjtMAApuZXdNYXhJb3BzdAAQTGphdmEvbGFuZy9Mb25nO0wACm5ld01pbklvcHNxAH4AAkwAFG5ld1NlcnZpY2VPZmZlcmluZ0lkcQB-AAJ4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1ldAASTGphdmEvbGFuZy9TdHJpbmc7eHAAAAAAAAAAAgAAAAAAAAACAAAAAAAAAB10ABRWb2x1bWVBcGlTZXJ2aWNlSW1wbAAAAAADIAAAAAAAAAMgAAAAAAAAAAAAAB9wcHBw,
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 32987898970999, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: Fri Aug 2
 0 18:31:22 UTC 2021, removed: null}
   2021-08-20 18:31:23,902 DEBUG [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375) (logid:cf6a9431) Run VM 
work job: com.cloud.vm.VmWorkResizeVolume for VM 29, job origin: 350
   2021-08-20 18:31:23,903 DEBUG [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Execute VM work job: 
com.cloud.vm.VmWorkResizeVolume{"volumeId":31,"currentSize":52428800,"newSize":52428800,"shrinkOk":false,"userId":2,"accountId":2,"vmId":29,"handlerName":"VolumeApiServiceImpl"}
   2021-08-20 18:31:23,906 DEBUG [c.c.s.StorageManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Checking pool 2 for storage, totalSize: 2197949513728, 
usedBytes: 1025024983040, usedPct: 0.46635510808500247, disable threshold: 0.85
   2021-08-20 18:31:23,906 DEBUG [c.c.s.StorageManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Destination pool id: 2
   2021-08-20 18:31:23,911 DEBUG [c.c.h.o.r.Ovm3HypervisorGuru] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) getCommandHostDelegation: class 
com.cloud.agent.api.storage.ResizeVolumeCommand
   2021-08-20 18:31:23,911 DEBUG [c.c.h.XenServerGuru] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) We are returning the default host to execute commands because 
the command is not of Copy type.
   2021-08-20 18:31:23,913 DEBUG [c.c.a.t.Request] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Seq 2-5682135354858017887: Sending  { Cmd , MgmtId: 
32987898970999, via: 2(ref-trl-1093-k-M7-nicolas-vazquez-kvm2), Ver: v1, Flags: 
100011, 
[{"com.cloud.agent.api.storage.ResizeVolumeCommand":{"path":"28223522-eae5-4004-89da-aedbe360782c","pool":{"id":"2","uuid":"88ab8905-5d8f-35f8-8677-8b2e6561b8ad","host":"10.0.32.4","path":"/acs/primary/ref-trl-1093-k-M7-nicolas-vazquez/ref-trl-1093-k-M7-nicolas-vazquez-kvm-pri2","port":"2049","type":"NetworkFilesystem"},"currentSize":"52428800","newSize":"(50.00
 MB) 
52428800","shrinkOk":"false","vmInstance":"i-2-29-VM","managed":"false","wait":"0","bypassHostMaintenance":"false"}}]
 }
   2021-08-20 18:31:23,955 DEBUG [c.c.a.t.Request] 
(AgentManager-Handler-12:null) (logid:) Seq 2-5682135354858017887: Processing:  
{ Ans: , MgmtId: 32987898970999, via: 2, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.storage.ResizeVolumeAnswer":{"newSize":"(50.00 MB) 
52428800","result":"true","details":"success","wait":"0","bypassHostMaintenance":"false"}}]
 }
   2021-08-20 18:31:23,955 DEBUG [c.c.a.t.Request] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Seq 2-5682135354858017887: Received:  { Ans: , MgmtId: 
32987898970999, via: 2(ref-trl-1093-k-M7-nicolas-vazquez-kvm2), Ver: v1, Flags: 
10, { ResizeVolumeAnswer } }
   2021-08-20 18:31:23,955 DEBUG 
[o.a.c.s.d.d.CloudStackPrimaryDataStoreDriverImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Resize: volume started at size: (50.00 MB) 52428800 and ended 
at size: (50.00 MB) 52428800
   2021-08-20 18:31:23,962 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Updating resource Type = primary_storage count for Account = 2 
Operation = increasing Amount = (0 bytes) 0
   2021-08-20 18:31:23,967 DEBUG [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Done executing VM work job: 
com.cloud.vm.VmWorkResizeVolume{"volumeId":31,"currentSize":52428800,"newSize":52428800,"shrinkOk":false,"userId":2,"accountId":2,"vmId":29,"handlerName":"VolumeApiServiceImpl"}
   2021-08-20 18:31:23,968 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Complete async job-375, jobStatus: SUCCEEDED, resultCode: 0, 
result: 
rO0ABXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAAAAAAAAHw
   2021-08-20 18:31:23,969 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Publish async job-375 complete on message bus
   2021-08-20 18:31:23,969 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Wake up jobs related to job-375
   2021-08-20 18:31:23,969 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Update db status for job-375
   2021-08-20 18:31:23,969 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375 ctx-7f184d33) 
(logid:cf6a9431) Wake up jobs joined with job-375 and disjoin all subjobs 
created from job- 375
   2021-08-20 18:31:23,973 DEBUG [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375) (logid:cf6a9431) Done with 
run of VM work job: com.cloud.vm.VmWorkResizeVolume for VM 29, job origin: 350
   2021-08-20 18:31:23,973 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375) (logid:cf6a9431) Done 
executing com.cloud.vm.VmWorkResizeVolume for job-375
   2021-08-20 18:31:23,975 INFO  [o.a.c.f.j.i.AsyncJobMonitor] 
(Work-Job-Executor-50:ctx-53159f47 job-350/job-375) (logid:cf6a9431) Remove 
job-375 from job monitoring
   2021-08-20 18:31:23,988 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp1233705144-341:ctx-ca45c685 ctx-ca54d7a6 ctx-99d68cd7) (logid:eff47b8d) 
Updating resource Type = cpu count for Account = 2 Operation = increasing 
Amount = 1
   2021-08-20 18:31:23,991 DEBUG [c.c.r.ResourceLimitManagerImpl] 
(qtp1233705144-341:ctx-ca45c685 ctx-ca54d7a6 ctx-99d68cd7) (logid:eff47b8d) 
Updating resource Type = memory count for Account = 2 Operation = increasing 
Amount = 1536
   2021-08-20 18:31:24,009 DEBUG [c.c.a.ApiServlet] 
(qtp1233705144-341:ctx-ca45c685 ctx-ca54d7a6 ctx-99d68cd7) (logid:eff47b8d) 
===END===  172.16.250.2 -- GET  
apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=changeServiceForVirtualMachine&id=5298703e-2b13-454e-8dc7-a89391ca10cf&response=json&serviceofferingid=dbffb956-e1ea-4e23-aa3b-6ff86b802753&signature=g0bjxAG4fuAsPwwwr6xNdsAycNI%3D
   ````
   
   @rhtyd do we want the same behaviour in `scaleVirtualMachine` API?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to