nvazquez commented on a change in pull request #1257:
URL: https://github.com/apache/cloudstack/pull/1257#discussion_r694463880
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -446,6 +449,29 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
}
}
+ private HostMO getOldestExistentHostInCluster(Long clusterId,
VmwareContext serviceContext) throws Exception {
+ HostVO host =
hostDao.findOldestExistentHypervisorHostInCluster(clusterId);
+ if (host == null) {
+ return null;
+ }
+
+ ManagedObjectReference morSrcHost =
HypervisorHostHelper.getHypervisorHostMorFromGuid(host.getGuid());
+ if (morSrcHost == null) {
+ Map<String, String> clusterDetails =
clusterDetailsDao.findDetails(clusterId);
+ if (clusterDetails.get("url") == null) {
Review comment:
Can we use `StringUtils.isBlank(..)` here, since cluster_details does
not accept null values anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
