DaanHoogland commented on a change in pull request #4966:
URL: https://github.com/apache/cloudstack/pull/4966#discussion_r696387624
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4390,13 +4390,18 @@ public VMInstanceVO reConfigureVm(final String vmUuid,
final ServiceOffering old
VirtualMachine vm = retrieveVmFromJobOutcome(outcome, vmUuid,
"reconfigureVm");
+ Object result = null;
try {
- retrieveResultFromJobOutcomeAndThrowExceptionIfNeeded(outcome);
- } catch (InsufficientCapacityException ex) {
+ result =
retrieveResultFromJobOutcomeAndThrowExceptionIfNeeded(outcome);
+
+ if (result == null) {
+ return (VMInstanceVO)vm;
+ }
+ } catch (Exception ex) {
Review comment:
I'm not particular fond of this. much rather see the statement outside
the try/catch and be
```
if (result != null) {
throw new RuntimeException("Unexpected job execution result");
}
return (VMInstanceVO)vm;
```
(no :-1: by any means though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
