harikrishna-patnala commented on a change in pull request #5008:
URL: https://github.com/apache/cloudstack/pull/5008#discussion_r698974611
##########
File path:
engine/api/src/main/java/org/apache/cloudstack/engine/service/api/OrchestrationService.java
##########
@@ -67,14 +67,15 @@ VirtualMachineEntity createVirtualMachine(@QueryParam("id")
String id, @QueryPar
@QueryParam("compute-tags") List<String> computeTags,
@QueryParam("root-disk-tags") List<String> rootDiskTags,
@QueryParam("network-nic-map") Map<String, List<NicProfile>>
networkNicMap, @QueryParam("deploymentplan") DeploymentPlan plan,
@QueryParam("root-disk-size") Long rootDiskSize,
@QueryParam("extra-dhcp-option-map") Map<String, Map<Integer, String>>
extraDhcpOptionMap,
- @QueryParam("datadisktemplate-diskoffering-map") Map<Long,
DiskOffering> datadiskTemplateToDiskOfferingMap) throws
InsufficientCapacityException;
+ @QueryParam("datadisktemplate-diskoffering-map") Map<Long,
DiskOffering> datadiskTemplateToDiskOfferingMap,
@QueryParam("disk-offering-id") Long diskOfferingId,
@QueryParam("root-disk-offering-id") Long rootDiskOfferingId) throws
InsufficientCapacityException;
Review comment:
there are usages these methods @rhtyd, so I changed it accordingly
https://github.com/apache/cloudstack/blob/6d4a74b27b7c35cfe170cbac621874d2a6b6e537/server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L4270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
