[GitHub] [cloudstack] shwstppr commented on a change in pull request #5380: vmware: check checksum before copying systemvm ISO to decide if it is needed

[GitBox]

shwstppr commented on a change in pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#discussion_r699004797



##########
File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
         _storageMgr = new VmwareStorageManagerImpl(this);
     }
 
+    private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+        boolean copyNeeded = !destIso.exists();
+        if (!copyNeeded) {
+            try {
+                copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new 
FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));

Review comment:
       Added

##########
File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
         _storageMgr = new VmwareStorageManagerImpl(this);
     }
 
+    private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+        boolean copyNeeded = !destIso.exists();
+        if (!copyNeeded) {
+            try {
+                copyNeeded = !StringUtils.equals(DigestUtils.md5Hex(new 
FileInputStream(srcIso)), DigestUtils.md5Hex(new FileInputStream(destIso)));

Review comment:
       Done

##########
File path: 
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,18 @@ public VmwareManagerImpl() {
         _storageMgr = new VmwareStorageManagerImpl(this);
     }
 
+    private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+        boolean copyNeeded = !destIso.exists();
+        if (!copyNeeded) {

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org