nvazquez commented on a change in pull request #5390:
URL: https://github.com/apache/cloudstack/pull/5390#discussion_r698922195
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -886,6 +886,7 @@ public UserVm resetVMSSHKey(ResetVMSSHKeyCmd cmd) throws
ResourceUnavailableExce
throw new CloudRuntimeException("Failed to reset SSH Key for the
virtual machine ");
}
+ _vmDao.loadDetails(userVm);
Review comment:
I would prefer removing this line and including it into the
`removeEncryptedPasswordFromUserVmVoDetails` method if the VM details are empty
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -886,6 +886,7 @@ public UserVm resetVMSSHKey(ResetVMSSHKeyCmd cmd) throws
ResourceUnavailableExce
throw new CloudRuntimeException("Failed to reset SSH Key for the
virtual machine ");
}
+ _vmDao.loadDetails(userVm);
Review comment:
I would prefer moving this line into the
`removeEncryptedPasswordFromUserVmVoDetails` method if the VM details are empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
