shwstppr commented on a change in pull request #5392:
URL: https://github.com/apache/cloudstack/pull/5392#discussion_r700037826
##########
File path: ui/src/views/compute/wizard/ComputeSelection.vue
##########
@@ -25,7 +25,7 @@
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
+ <a-col :md="10" :lg="10" v-show="isConstrained && maxCpu &&
isNaN(maxCpu)">
Review comment:
@utchoang is this show condition correct here. For memory you have used
reversed for isNaN which probably makes sense
##########
File path: ui/src/views/compute/wizard/ComputeSelection.vue
##########
@@ -25,7 +25,7 @@
:validate-status="errors.cpu.status"
:help="errors.cpu.message">
<a-row :gutter="12">
- <a-col :md="10" :lg="10" v-show="isConstrained">
+ <a-col :md="10" :lg="10" v-show="isConstrained && maxCpu &&
isNaN(maxCpu)">
Review comment:
@utchoang is this show condition correct here? For memory you have used
reversed for isNaN which probably makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
