shwstppr commented on a change in pull request #5380:
URL: https://github.com/apache/cloudstack/pull/5380#discussion_r700766551
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -263,6 +268,24 @@ public VmwareManagerImpl() {
_storageMgr = new VmwareStorageManagerImpl(this);
}
+ private boolean isSystemVmIsoCopyNeeded(File srcIso, File destIso) {
+ if (!destIso.exists()) {
+ return true;
+ }
+ boolean copyNeeded = false;
+ try {
+ String srcIsoMd5 = DigestUtils.md5Hex(new FileInputStream(srcIso));
Review comment:
```
private File getSystemVMPatchIsoFile() {
// locate systemvm.iso
URL url =
this.getClass().getClassLoader().getResource("vms/systemvm.iso");
File isoFile = null;
if (url != null) {
isoFile = new File(url.getPath());
}
if (isoFile == null || !isoFile.exists()) {
isoFile = new
File("/usr/share/cloudstack-common/vms/systemvm.iso");
}
assert (isoFile != null);
if (!isoFile.exists()) {
s_logger.error("Unable to locate systemvm.iso in your setup at "
+ isoFile.toString());
}
return isoFile;
}
```
Method(existed before this PR) used for getting `srcIso` covers that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
