Pearl1594 commented on a change in pull request #5428:
URL: https://github.com/apache/cloudstack/pull/5428#discussion_r707177109
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4927,11 +4927,10 @@ public void finalizeStop(VirtualMachineProfile profile,
Answer answer) {
if (owner.getState() == Account.State.disabled) {
throw new PermissionDeniedException("The owner of " + vm + " is
disabled: " + vm.getAccountId());
}
- if (VirtualMachineManager.ResoureCountRunningVMsonly.value()) {
- // check if account/domain is with in resource limits to start a
new vm
- ServiceOfferingVO offering =
_serviceOfferingDao.findById(vm.getId(), vm.getServiceOfferingId());
- resourceLimitCheck(owner, vm.isDisplayVm(), new
Long(offering.getCpu()), new Long(offering.getRamSize()));
- }
+
Review comment:
Based on my understanding, operations like scaleVM - which could update
the vm settings prior starting the VM, and other such operations, have these
checks in place, so it may become redundant. However, keeping this check may be
safer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
