DaanHoogland commented on a change in pull request #5353:
URL: https://github.com/apache/cloudstack/pull/5353#discussion_r708349655
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##########
@@ -1002,6 +1003,7 @@ private void
exportVolumeToSecondaryStorage(VirtualMachineMO vmMo, String volume
vmMo.removeSnapshot(exportName, false);
}
if (workerVm != null) {
+ //detach volume and destroy worker vm
Review comment:
this comment is just saying the name of the method below. let's not add
it.
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1120,6 +1120,7 @@ private String getVolumePathInDatastore(DatastoreMO dsMo,
String volumeFileName,
vmMo.removeSnapshot(exportName, false);
}
if (workerVm != null) {
+ //detach volume and destroy worker vm
Review comment:
this comment is just saying the name of the method below. let's not add
it.
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1982,6 +1983,7 @@ public Answer backupSnapshot(CopyCommand cmd) {
try {
if (workerVm != null) {
+ // detach volume and destroy worker vm
Review comment:
this comment is just saying the name of the method below. let's not add
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
