SadiJr commented on a change in pull request #5454:
URL: https://github.com/apache/cloudstack/pull/5454#discussion_r710109613



##########
File path: ui/src/views/offering/ImportBackupOffering.vue
##########
@@ -167,7 +167,7 @@ export default {
             params[key] = input
           }
         }
-        params.allowuserdrivenbackups = values.allowuserdrivenbackups ? 
values.allowuserdrivenbackups : true
+        params.allowuserdrivenbackups = values.allowuserdrivenbackups == null 
? true : values.allowuserdrivenbackups

Review comment:
       This change was made to fix the reported bug of `Allow User Driven 
Backups` parameter.
   
   In the old code, when user set this parameter as `false`, this check, as it 
is a ternary operation, it always ended up sending the parameter as `true`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to