GutoVeronezi commented on a change in pull request #4438:
URL: https://github.com/apache/cloudstack/pull/4438#discussion_r714719902
##########
File path:
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
##########
@@ -460,14 +567,20 @@ public ItemVMCore(final String zn, final String zu, final
String hn, final Strin
core = cr;
}
isDedicated = dedicated;
+ hosttags = tags;
}
@Override
public String toMetricsString() {
- if (Strings.isNullOrEmpty(hostName) && Strings.isNullOrEmpty(ip)) {
- return String.format("%s{zone=\"%s\",filter=\"%s\"} %d", name,
zoneName, filter, core);
+ if (StringUtils.isEmpty(hostName) && StringUtils.isEmpty(ip)) {
Review comment:
We could use `StringUtils#isAllEmpty`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
