soreana commented on a change in pull request #4438:
URL: https://github.com/apache/cloudstack/pull/4438#discussion_r714776010
##########
File path:
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
##########
@@ -524,14 +647,20 @@ public ItemHostMemory(final String zn, final String zu,
final String hn, final S
filter = fl;
miBytes = membytes / (1024.0 * 1024.0);
isDedicated = dedicated;
+ hosttags = tags;
}
@Override
public String toMetricsString() {
- if (Strings.isNullOrEmpty(hostName) && Strings.isNullOrEmpty(ip)) {
- return String.format("%s{zone=\"%s\",filter=\"%s\"} %.2f",
name, zoneName, filter, miBytes);
+ if (StringUtils.isEmpty(hostName) && StringUtils.isEmpty(ip)) {
Review comment:
Cool, I didn't know it exists :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
