sureshanaparti commented on a change in pull request #5539:
URL: https://github.com/apache/cloudstack/pull/5539#discussion_r719170573
##########
File path:
core/src/main/java/com/cloud/agent/api/storage/ResizeVolumeCommand.java
##########
@@ -37,19 +38,20 @@
protected ResizeVolumeCommand() {
}
- public ResizeVolumeCommand(String path, StorageFilerTO pool, Long
currentSize, Long newSize, boolean shrinkOk, String vmInstance) {
+ public ResizeVolumeCommand(String path, StorageFilerTO pool, Long
currentSize, Long newSize, boolean shrinkOk, String vmInstance, String
chainInfo) {
Review comment:
Better to keep the existing constructor as it is, and define/use new
constructor as below. This way, no need to update all the calls. Same
applicable to _MigrateVolumeCommand_.
```
public ResizeVolumeCommand(String path, StorageFilerTO pool, Long
currentSize, Long newSize, boolean shrinkOk, String vmInstance, String
chainInfo) {
...
}
public ResizeVolumeCommand(String path, StorageFilerTO pool, Long
currentSize, Long newSize, boolean shrinkOk, String vmInstance) {
this(path, pool, currentSize, newSize, shrinkOk, vmInstance, null);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
