DaanHoogland commented on issue #3110: URL: https://github.com/apache/cloudstack/issues/3110#issuecomment-938457806
ignoring history and just looking at functional spec; > Now, both scaleVirtualMachine and changeServiceForVirtualMachine APIs allows volume resize operation, but have different checks/restrictions. I think neither should touch disks, their names sugest different behaviour. > > @rhtyd @nvazquez @GabrielBrascher @DaanHoogland @andrijapanicsb and others, please provide your inputs/thoughts on the following. > > * Should we keep these checks consistent for both APIs (atleast for the volume resize operation)? I don't think we need to as the names do sugest slightly different meaning. It would be nice to have statistics from the wild as proposed in the past (cc @wido ), to decide which is the one more widely used and with which parameters. Knowing that we can decide to deprecate one and keep the other. It makes sense to me to create a new one for the reason stated below and to keep service offering away from disks. This will mean a backwards compatibility issue. > > * There is a PR ([Decouple service (compute) offering and disk offering #5008](https://github.com/apache/cloudstack/pull/5008)) raised to decouple service and disk offerings. For backward compatibility, the volume resize operation is supported with these APIs for the service offerings mapped 1:1 with disk offerings (which are tagged is_compute_only). Should the volume resize operation be part of the disk offering change going forward? yes, it should. I do not think this will be appropriate work for a minor release though (as 4.16.1) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
