sureshanaparti commented on a change in pull request #5642:
URL: https://github.com/apache/cloudstack/pull/5642#discussion_r740158995
##########
File path:
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java
##########
@@ -458,10 +466,32 @@ private Long
createTemplateObjectInDB(SystemVMTemplateDetails details) {
template.setState(VirtualMachineTemplate.State.Inactive);
template.setDeployAsIs(Hypervisor.HypervisorType.VMware.equals(details.getHypervisorType()));
template = vmTemplateDao.persist(template);
- if (template == null) {
- return null;
+ return template;
+ }
+
+ private VMTemplateZoneVO createOrUpdateTemplateZoneEntry(long zoneId, long
templateId) {
+ VMTemplateZoneVO templateZoneVO =
vmTemplateZoneDao.findByZoneTemplate(zoneId, templateId);
+ if (templateZoneVO == null) {
+ templateZoneVO = new VMTemplateZoneVO(zoneId, templateId, new
java.util.Date());
+ templateZoneVO = vmTemplateZoneDao.persist(templateZoneVO);
+ } else {
+ templateZoneVO.setRemoved(GenericDaoBase.DATE_TO_NULL);
+ templateZoneVO.setLastUpdated(new java.util.Date());
+ if (vmTemplateZoneDao.update(templateZoneVO.getId(),
templateZoneVO)) {
+ templateZoneVO = null;
+ }
+ }
+ return templateZoneVO;
Review comment:
this returned _templateZoneVO_ is unused, and only being validated for
null. I think, it is better through the exception when the update fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
