rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748153805
##########
File path:
server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -259,9 +259,14 @@ private void setupAgentSecurity(final Connection
sshConnection, final String age
sshConnection = new Connection(agentIp, 22);
sshConnection.connect(null, 60000, 60000);
- if (!sshConnection.authenticateWithPassword(username, password)) {
- s_logger.debug("Failed to authenticate");
- throw new DiscoveredWithErrorException("Authentication error");
+
+ final String privateKey = _configDao.getValue("ssh.privatekey");
+ if
(!SSHCmdHelper.acquireAuthorizedConnectionWithPublicKey(sshConnection,
username, privateKey)) {
+ s_logger.error("Failed to authenticate with ssh key");
+ if (!sshConnection.authenticateWithPassword(username,
password)) {
Review comment:
Nit - maybe do a check if password was even passed (empty?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
