shwstppr commented on a change in pull request #5708:
URL: https://github.com/apache/cloudstack/pull/5708#discussion_r755028304
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -1765,7 +1765,7 @@ protected ScaleVmAnswer execute(ScaleVmCommand cmd) {
// Check if license supports the feature
VmwareHelper.isFeatureLicensed(hyperHost,
FeatureKeyConstants.HOTPLUG);
- VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(),
vmSpec.getMaxSpeed(), vmSpec.getMinSpeed(), (int) requestedMaxMemoryInMb, ramMb,
+ VmwareHelper.setVmScaleUpConfig(vmConfigSpec, vmSpec.getCpus(),
vmSpec.getMaxSpeed(), getReservedCpuMHZ(vmSpec), (int) requestedMaxMemoryInMb,
ramMb,
Review comment:
@rhtyd `getReservedCpuMHZ()` method seems to be using min CPU speed
itself based CPU reservation global setting.
https://github.com/apache/cloudstack/blob/4.16/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L3052-L3057
Same method is used while deploying VM,
https://github.com/apache/cloudstack/blob/4.16/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L1999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
