weizhouapache commented on a change in pull request #5675:
URL: https://github.com/apache/cloudstack/pull/5675#discussion_r756083718



##########
File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -3116,6 +3116,8 @@ public void doInTransactionWithoutResult(final 
TransactionStatus status) {
                                 if (networkAccount != null) {
                                     
_networkAccountDao.remove(networkAccount.getId());
                                 }
+
+                                
networkDetailsDao.removeDetails(networkFinal.getId());

Review comment:
       > 
   
   @sureshanaparti 
   yes, you are absolutely right. `ON DELETE CASCADE` does not work as expected 
because cloudstack updates `removed` field instead deleting the record from DB.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to