sureshanaparti commented on a change in pull request #5735:
URL: https://github.com/apache/cloudstack/pull/5735#discussion_r759871333
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##########
@@ -1306,12 +1307,12 @@ private void
setVolumeToPathAndSize(List<VolumeObjectTO> volumeTOs, Map<String,
// get volume's chain size for this VM snapshot; exclude current
volume vdisk
DataStoreTO store = volumeTO.getDataStore();
ManagedObjectReference morDs =
getDatastoreAsManagedObjectReference(baseName, hyperHost, store);
- long size = getVMSnapshotChainSize(context, hyperHost, baseName +
".vmdk", morDs, newPath);
- size = getVMSnapshotChainSize(context, hyperHost, baseName +
"-*.vmdk", morDs, newPath);
+ long size = getVMSnapshotChainSize(context, hyperHost, baseName +
".vmdk", morDs, newPath, vmName);
Review comment:
yes @Pearl1594, already created a separate PR
(https://github.com/apache/cloudstack/pull/5720) to remove the redundant call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
