soreana commented on a change in pull request #4438:
URL: https://github.com/apache/cloudstack/pull/4438#discussion_r768478844
##########
File path:
plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterImpl.java
##########
@@ -115,6 +122,10 @@ private void addHostMetrics(final List<Item> metricsList,
final long dcId, final
int total = 0;
int up = 0;
int down = 0;
+ Map<String, Integer> total_hosts = new HashMap<>();
Review comment:
@DaanHoogland I was thinking about refactoring the whole Prometheus
plugin. If I touch one method, I have to change everything. I love to do that,
but it would be out of the scope of this pr. I've created #5773 for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
